More comments and improved code readability#2
Open
AnomalRoil wants to merge 6 commits intooreparaz:masterfrom
AnomalRoil:patch-2
Open
More comments and improved code readability#2AnomalRoil wants to merge 6 commits intooreparaz:masterfrom AnomalRoil:patch-2
AnomalRoil wants to merge 6 commits intooreparaz:masterfrom
AnomalRoil:patch-2
Conversation
Since it may not be straightforward. (Yet, one should definitively check out Welford method to get it, I agree.)
Since this is not straightforward.
So it's easier to use without reading the code entirely.
This improves readability and clearly we always want to differentiate after we measure, so it is nicer to have the "temporary" ticks variables in there too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a few more changes I propose to help with readability.
You can pick whatever you want to keep ;)